Address hlint warnings/suggestions#1826
Merged
tchoutri merged 13 commits intohaskell-servant:masterfrom Aug 6, 2025
Merged
Conversation
Some FOURMOLU_DISABLE directives were added in problematic cases (mostly CPP conditional pragmas or foreign imports).
Address some hlints that required manual attention.
tchoutri
requested changes
Jul 17, 2025
servant-auth/servant-auth-server/src/Servant/Auth/Server/Internal/Cookie.hs
Outdated
Show resolved
Hide resolved
tchoutri
reviewed
Jul 30, 2025
tchoutri
approved these changes
Aug 4, 2025
Contributor
|
@zlondrej this is a big step forward, thank you very much for this work. Servant's code quality has certainly increased in ways that will make future development much easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed
hlint.yamlto.hlint.yamlso it's automatically applied.Disabled most of the ignore filters.
Note: this is based on #1825, so until that PR is merged, it will show additional changes.